Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding observability and otel #226

Merged
merged 3 commits into from
Sep 11, 2024
Merged

adding observability and otel #226

merged 3 commits into from
Sep 11, 2024

Conversation

asteurer
Copy link
Contributor

No description provided.

@asteurer
adding observability and otel
f7151d7 
Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>
@calebschoepp calebschoepp self-requested a review August 16, 2024 18:09
@asteurer asteurer mentioned this pull request Aug 16, 2024
Closed
@bacongobbler
Copy link
Contributor

bacongobbler commented Aug 16, 2024 •
edited
Loading

@asteurer @calebschoepp are these changes to the SpinApp manifest available in SpinKube 0.2.0, or will this feature be available in SpinKube 0.3.0? If the latter, we should hold off until 0.3.0 has been released because the documentation currently refers to installing and maintaining SpinKube 0.2.0.

@calebschoepp
Copy link
Contributor

@asteurer @calebschoepp are these changes to the SpinApp manifest available in SpinKube 0.2.0, or will this feature be available in SpinKube 0.3.0? If the latter, we should hold off until 0.3.0 has been released because the documentation currently refers to installing and maintaining SpinKube 0.2.0.

Good point. They'll be in 0.3.0 so we should wait.

calebschoepp
calebschoepp requested changes Aug 19, 2024
View reviewed changes
content/en/docs/topics/observing-spinkube.md Outdated Show resolved Hide resolved
content/en/docs/topics/observing-spinkube.md Outdated Show resolved Hide resolved
content/en/docs/topics/observing-spinkube.md Outdated Show resolved Hide resolved
@bacongobbler bacongobbler added the DO NOT MERGE Blocks a pull request from being merged. label Aug 19, 2024
@bacongobbler
Copy link
Contributor

Labelling as DO NOT MERGE until SpinKube 0.3.0 has been released.

@asteurer
making requested changes
27df02a 
Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>
@asteurer
updating the otel-collector Helm install code to work on both ZSH and…
3838bbc 
… BASH

Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>
@calebschoepp
Copy link
Contributor

@bacongobbler shall we merge this now?

@calebschoepp calebschoepp removed the DO NOT MERGE Blocks a pull request from being merged. label Sep 11, 2024
@calebschoepp calebschoepp merged commit de863e8 into spinkube:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebschoepp calebschoepp calebschoepp approved these changes

@bacongobbler bacongobbler bacongobbler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asteurer @bacongobbler @calebschoepp